Skip to content

[Enhancement] Support no-IRQ for SPI Ethernet W5500 #9251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Feb 22, 2024
Merged

[Enhancement] Support no-IRQ for SPI Ethernet W5500 #9251

merged 5 commits into from
Feb 22, 2024

Conversation

TD-er
Copy link
Contributor

@TD-er TD-er commented Feb 15, 2024

Requires this commit from ESP-IDF to be cherry picked: espressif/esp-idf@fd0a1dc

Related discussion: espressif/esp-idf#12682 (comment)

Fixes: #9246

@TD-er
[W5500] Support no-IRQ
257a99f 
Requires this commit from ESP-IDF to be cherry picked:
espressif/esp-idf@fd0a1dc
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 15, 2024 •
edited
Loading

Warnings
⚠️

Some issues found for the commit messages in this PR:

  • the commit message "Guard feature to be enabled when IDF backports it to v5.1":
    • summary looks empty
    • type/action looks empty
  • the commit message "Remove unrelated code to support ETH_PHY_JL1101":
    • summary looks empty
    • type/action looks empty
  • the commit message "[W5500] Support no-IRQ":
    • summary looks empty
    • type/action looks empty
  • the commit message "remove the commented check and fix the error message":
    • summary looks empty
    • type/action looks empty

Please fix these commit messages - here are some basic tips:

  • follow Conventional Commits style
  • correct format of commit message should be: <type/action>(<scope/component>): <summary>, for example fix(esp32): Fixed startup timeout issue
  • allowed types are: change,ci,docs,feat,fix,refactor,remove,revert,test
  • sufficiently descriptive message summary should be between 20 to 72 characters and start with upper case letter
  • avoid Jira references in commit messages (unavailable/irrelevant for our customers)

TIP: Install pre-commit hooks and run this check when committing (uses the Conventional Precommit Linter).
Messages
📖 You might consider squashing your 5 commits (simplifying branch history).

👋 Hello TD-er, we appreciate your contribution to this project!

Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- Resolve all warnings (⚠️ ) before requesting a review from human reviewers - they will appreciate it.
- Addressing info messages (📖) is strongly recommended; they're less critical but valuable.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against 35d0cdc

@TD-er TD-er changed the title [W5500] Support no-IRQ [Enhancement] Support no-IRQ for SPI Ethernet W5500 Feb 15, 2024
@Jason2866
Copy link
Collaborator

@TD-er This is not in official version (Tasmota fork only)

case ETH_PHY_JL1101:
            phy = esp_eth_phy_new_jl1101(&phy_config);
            break;

Needs to be removed.

@me-no-dev
Copy link
Member

this will have to first be backported from IDF.

@TD-er
Copy link
Contributor Author

TD-er commented Feb 15, 2024

this will have to first be backported from IDF.

Absolutely, but when that's done it is very easy to implement :)

@me-no-dev
Copy link
Member

@TD-er updated the PR to be able to merge it now and enable the feature with define, once it's available from IDF

@TD-er
Copy link
Contributor Author

TD-er commented Feb 22, 2024

Ah good to know, so I should not forget to add those defines in my own builds or else it won't work with my own builds when updating the Arduino code :)

@me-no-dev
Copy link
Member

@TD-er you can add #define ETH_SPI_SUPPORTS_NO_IRQ 1 to ETH.h or globally define it in the build to enable the feature

@me-no-dev me-no-dev merged commit 113de1f into espressif:master Feb 22, 2024
@TD-er
Copy link
Contributor Author

TD-er commented Feb 22, 2024

@TD-er Yep, already add it to my platformIO config or else I'm sure I will forget it later :)
Thanks for merging.

@TD-er TD-er deleted the patch-2 branch February 22, 2024 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@me-no-dev me-no-dev me-no-dev left review comments

@lucasssvaz lucasssvaz Awaiting requested review from lucasssvaz

Assignees
No one assigned
Labels
Area: ESP-IDF related ESP-IDF related issues Area: WiFi Issue related to WiFi Status: Blocked by ESP-IDF
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[W5500] M5Stack AtomPoE doesn't have INT/RST connected
5 participants
@TD-er @Jason2866 @me-no-dev @VojtechBartoska @lucasssvaz